Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows gradle bug #20293

Closed
wants to merge 1 commit into from
Closed

fix windows gradle bug #20293

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Jul 19, 2018 •
edited
Loading

Motivation

fix windows gradle bug, you can also see full log in https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.11/job/ic0nml8s4qbmni4e.

FAILURE: Build failed with an exception.

* What went wrong:
Failed to capture snapshot of input files for task ':RNTester:android:app:bundleReleaseJsAndAssets' property '$1' during up-to-date check.
> Failed to create MD5 hash for file content.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Build success log: https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.12/job/xuaj8tm3p1piovbt.

Test Plan

pass all current ci.

Related PRs

#20281

Release Notes

[GENERAL] [INTERNAL] [RNTester] - fix windows gradle bug

@gengjiawen gengjiawen requested a review from hramos as a code owner July 19, 2018 15:35
@gengjiawen gengjiawen force-pushed the feature/windows_gradle branch from 0a4c4d6 to 17f9aa6 Compare July 19, 2018 15:35
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2018
@gengjiawen
Copy link
Contributor Author

@hramos @kelset Please review.

@kelset
Copy link
Contributor

kelset commented Jul 19, 2018

Can you add a couple more lines in the PR description explaining which error you were seeing? I guess we will also have to "counter-check" that that change in the ignore doesn't break builds on macOS (or the CI already "takes care" of that?).

Do you have any external references about the Windows bug, I mean, is it like a known bug on Windows that requires to make that change in the build.gradle?

@gengjiawen
Copy link
Contributor Author

@kelset I add full error info in motivation. This is a bug only windows, so unix-like system works just as I tested. Related gradle bug: gradle/gradle#4663.

@react-native-bot react-native-bot added ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Jul 19, 2018
@gengjiawen
Copy link
Contributor Author

With this pr and #19974, all build issue on windows should be resolved.

@kelset
Copy link
Contributor

kelset commented Jul 19, 2018

Understood.
I'd just wait a bit to hear back from the Metro team because I'm quite sure they have another release coming soon and I'd prefer to have everything double checked against their new version.

@gengjiawen
Copy link
Contributor Author

@hramos Can you review this pr ? Thanks.

@gengjiawen
Copy link
Contributor Author

@hramos This fix will greatly help windows user to test RNTester like me. Can you review this ? Thanks.

@kelset kelset added the Platform: Windows Building on Windows. label Jul 23, 2018
@gengjiawen gengjiawen mentioned this pull request Jul 23, 2018
Closed
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jul 30, 2018
facebook-github-bot
facebook-github-bot approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @gengjiawen in 847261b.

Once this commit is added to a release, you will see the corresponding version tag below the description at 847261b. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 31, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 31, 2018
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Aug 17, 2018
@gengjiawen @facebook-github-bot
fix windows gradle bug (#20293)
c4505b1 
Summary:
fix windows gradle bug, you can also see full log in https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.11/job/ic0nml8s4qbmni4e.
```
FAILURE: Build failed with an exception.

* What went wrong:
Failed to capture snapshot of input files for task ':RNTester:android:app:bundleReleaseJsAndAssets' property '$1' during up-to-date check.
> Failed to create MD5 hash for file content.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org
```
Build success log: https://ci.appveyor.com/project/gengjiawen/react-native/build/1.0.12/job/xuaj8tm3p1piovbt.

pass all current ci.
facebook/react-native#20281
 [GENERAL] [INTERNAL] [RNTester] - fix windows gradle bug
Pull Request resolved: facebook/react-native#20293

Differential Revision: D9071261

Pulled By: hramos

fbshipit-source-id: 87fab94d15d78dac1db51f15ca5f4ea9e3a6ad04
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Platform: Windows Building on Windows.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @kelset @react-native-bot @facebook-github-bot @hramos